Init category indexer #858
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supercid
commented
Jul 18, 2024
…n of logic for new indexer
…ento2 into feature/category-indexer
supercid
commented
Sep 30, 2024
supercid
commented
Sep 30, 2024
Model/Category/Repository.php
Outdated
| public function getCategoryCollectionQuery(Store $store, array $categoryIds = []) | ||
| { | ||
| $categories = $this->categoryCollectionFactory->create() | ||
| ->distinct(true) |
There was a problem hiding this comment.
You can ignore this CS error, since we don't want duplicate ID's
supercid
commented
Sep 30, 2024
| * | ||
| * @param array $ids | ||
| */ | ||
| public function getByIds(array $ids) |
There was a problem hiding this comment.
You can remove this method if it is not being used
| { | ||
| $this->parentCategoryIdCache[$category->getId()] = $parentCategoryIds; | ||
| } | ||
|
|
Model/Indexer/Dimensions/ModeSwitcher/ModeSwitcherConfiguration.php
Outdated
Show resolved
Hide resolved
| { | ||
| $store = $this->nostoScopeHelper->getStore($storeId); | ||
| $categoryCollection = $this->collectionFactory->create() | ||
| ->addIdsToFilter($categoryIds) |
There was a problem hiding this comment.
You need to inherit from Magento\Catalog\Model\ResourceModel\Category and create this method, so we can filter by ID when calling the export controller
| /** @var CategoryInterface $category */ | ||
| foreach ($collection->getItems() as $category) { | ||
| try { | ||
| $parents = $this->nostoCategoryRepository->resolveParentCategoryIds($category); |
…ento2 into feature/category-indexer
supercid
commented
Nov 29, 2024
| $productCollection = $this->collectionFactory->create() | ||
| ->addIdsToFilter($productIds) | ||
| ->addStoreFilter($storeId); | ||
| $this->syncService->syncProducts($productCollection, $store); |
There was a problem hiding this comment.
@ugljesaspx
You're sending categories, not products. Please check this properly and which syncService is this, should be a syncService for categories, not products.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Documentation:
Checklist: